feat(RunningQueries): add userSID search #1462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
requested changes
Oct 15, 2024
| <React.Fragment> | ||
| {error ? <ResponseError error={parseQueryErrorToString(error)} /> : null} | ||
| <TableWithControlsLayout.Table loading={isFetching && data === undefined}> | ||
| <TableWithControlsLayout.Table loading={isFetching && !data.length}> |
Member
There was a problem hiding this comment.
You should change it to something like in TopQueriesData:
loading={isFetching && currentData === undefined}
Or not initialize data with an empty array and use data === undefined
Currently, loader is shown on autorefresh when there is no data, because it is isFetching=true and data.length=0
artemmufazalov
previously approved these changes
Oct 16, 2024
astandrik
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mixed search by query text and userSID
Demo
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: ✅
Current: 78.95 MB | Main: 78.96 MB
Diff: 0.00 MB (-0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information